Build fails on Windows: error C7555: use of designated initializers requires at least '/std:c++20'

[daljit97]

Hi, I've tried to build this library on Windows 11 and MSVC2019, but the build fails. The following error seems to be responsible:

C:\Users\Documents\ink-stroke-modeler\_deps\gtest-src\googletest\src\gtes
t-all.cc(38,10): fatal error C1083: Cannot open include file: 'gtest/gtest.h':
No such file or directory
...

C:\Users\Documents\ink-stroke-modeler\ink_stroke_modeler/types.h(183,11):
 error C7555: use of designated initializers requires at least '/std:c++20' [C:
\Users\Documents\ink-stroke-modeler\ink_stroke_modeler\ink_stroke_modeler
_types.vcxproj]
C:\Users\Documents\ink-stroke-modeler\ink_stroke_modeler/types.h(186,11):
 error C7555: use of designated initializers requires at least '/std:c++20' [C:
\Users\Documents\ink-stroke-modeler\ink_stroke_modeler\ink_stroke_modeler
_types.vcxproj]
C:\Users\Documents\ink-stroke-modeler\ink_stroke_modeler/types.h(189,11):
 error C7555: use of designated initializers requires at least '/std:c++20'

I see from the cmake scripts that that gtest should be fetched automatically, so not sure why the first error occurs (I was able to fix the first error using gtest from vcpkg).
Also, not sure if there are any plans for this already but it'd be really nice if this library could be made available through vcpkg.

[sfreilich]

We're not doing any work to support Windows upstream for this library, and we haven't done any formal release process / package manager integration for this. Happy to accept patches, though.