Repository navigation
Use a valid cgroup v1 memory update - #15465
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
TestCgroupV1 tried to lower the container's memory limit to 1 MiB when 2e1cd0e added update coverage. Docker rejected that request before invoking runsc because its minimum is 6 MiB [1]. Lower the limit from 1 GiB to 512 MiB instead, keeping it above the test's 500 MiB reservation. This lets the test reach runsc's update path and check the resulting cgroup attributes. [1]: https://github.com/moby/moby/blob/fca702de7/daemon/daemon_unix.go#L380-L385 Assisted-by: Codex <!-- codex-thread: 01a0680f-bbf5-7511-95f7-4414f4e10d2e --> FUTURE_COPYBARA_INTEGRATE_REVIEW=#15330 from tamird:cgroup-v1-memory-update a75fe7b PiperOrigin-RevId: 995315433
copybara-service
Bot
requested review from
EtiennePerot and
fvoznika
as code owners
October 7, 2026 20:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a valid cgroup v1 memory update
TestCgroupV1 tried to lower the container's memory limit to 1 MiB when
2e1cd0e added update coverage. Docker rejected that request before
invoking runsc because its minimum is 6 MiB 1.
Lower the limit from 1 GiB to 512 MiB instead, keeping it above the
test's 500 MiB reservation. This lets the test reach runsc's update path
and check the resulting cgroup attributes.
Assisted-by: Codex
FUTURE_COPYBARA_INTEGRATE_REVIEW=#15330 from tamird:cgroup-v1-memory-update a75fe7b