Repository navigation
Conversation
Use the Go rules' static attribute for tools and benchmark tests that requested fully_static_link. rules_go discards the C toolchain's -static flag [1] and adds it back only when its own static mode is enabled [2]. The feature alone could therefore leave race builds dynamically linked, exposing them to the host's libc requirements despite requesting static binaries. [1]: https://github.com/bazel-contrib/rules_go/blob/9792f1c07/go/private/actions/link.bzl#L59 [2]: https://github.com/bazel-contrib/rules_go/blob/9792f1c07/go/private/actions/link.bzl#L103-L104 Assisted-by: Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the Go rules' static attribute for tools and benchmark tests that
requested fully_static_link. rules_go discards the C toolchain's -static
flag 1 and adds it back only when its own static mode is enabled 2.
The feature alone could therefore leave race builds dynamically linked,
exposing them to the host's libc requirements despite requesting static
binaries.
Assisted-by: Codex