Repository navigation
nvproxy: move HostDriverVersion into nvconf; resolve latest in sentry - #15459
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
requested review from
EtiennePerot and
fvoznika
as code owners
October 7, 2026 18:45
runsc/sandbox imports //pkg/sentry/devices/nvproxy for two things: probing the host driver version, and resolving --nvproxy-driver-version=latest. That import links the full nvproxy ABI table, and with it the sentry kernel, VFS and MM packages, into the runsc binary. HostDriverVersion needs only an ioctl on /dev/nvidiactl, so move it to the nvconf leaf package, which already probes other host driver settings. Resolving "latest" needs the ABI table, which only the sentry has to link. runsc now passes "latest" through --nvidia-driver-version, and the boot command resolves it with nvproxy.LatestDriver(), yielding the same version as before. Nothing else in runsc used the resolved version. runsc/sandbox now depends only on nvconf. FUTURE_COPYBARA_INTEGRATE_REVIEW=#15365 from ayushr2:nvconf-host-driver-version 2b1d212 PiperOrigin-RevId: 995240930
copybara-service
Bot
force-pushed
the
test/cl995240930
branch
from
October 8, 2026 00:21
12feaa3 to
31783dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nvproxy: move HostDriverVersion into nvconf; resolve latest in sentry
runsc/sandbox imports //pkg/sentry/devices/nvproxy for two things: probing
the host driver version, and resolving --nvproxy-driver-version=latest. That
import links the full nvproxy ABI table, and with it the sentry kernel, VFS
and MM packages, into the runsc binary.
HostDriverVersion needs only an ioctl on /dev/nvidiactl, so move it to the
nvconf leaf package, which already probes other host driver settings.
Resolving "latest" needs the ABI table, which only the sentry has to link.
runsc now passes "latest" through --nvidia-driver-version, and the boot
command resolves it with nvproxy.LatestDriver(), yielding the same version
as before. Nothing else in runsc used the resolved version.
runsc/sandbox now depends only on nvconf.
FUTURE_COPYBARA_INTEGRATE_REVIEW=#15365 from ayushr2:nvconf-host-driver-version 2b1d212