Repository navigation
Conversation
The TUN device interface required contiguous Views, copying outgoing packet segments into one Go heap allocation. Pass Buffers through the device and its file-description caller, copying only the fixed-size headers needed to parse incoming packets. Linux accepts TUN writes beyond the interface MTU. Supporting those writes with fallible allocation requires retaining storage managed by the sentry's memory allocator; flattening would copy it back onto the Go heap. This change prepares that path without changing write limits or allocation. Copy reads up to the smaller of the packet and destination sizes, and preserve copy errors instead of clearing them after a partial transfer. Use an independent cursor to parse incoming headers before removing them from the packet buffer. Assisted-by: Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TUN device interface required contiguous Views, copying outgoing
packet segments into one Go heap allocation. Pass Buffers through the
device and its file-description caller, copying only the fixed-size
headers needed to parse incoming packets.
Linux accepts TUN writes beyond the interface MTU. Supporting those
writes with fallible allocation requires retaining storage managed by
the sentry's memory allocator; flattening would copy it back onto the
Go heap. This change prepares that path without changing write limits
or allocation.
Copy reads up to the smaller of the packet and destination sizes, and
preserve copy errors instead of clearing them after a partial transfer.
Use an independent cursor to parse incoming headers before removing
them from the packet buffer.
Assisted-by: Codex