Skip to content

Accept single-bit ranges in bitmap lists #15446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Oct 7, 2026
+3 −3
Merged

Accept single-bit ranges in bitmap lists #15446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/bitmap/format.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,8 @@ func parseToken(token string) (start, end uint32, err error) {
if err != nil {
return 0, 0, err
}
if val1 >= val2 {
return 0, 0, fmt.Errorf("start (%v) must be less than end (%v)", val1, val2)
if val1 > val2 {
return 0, 0, fmt.Errorf("start (%v) must not exceed end (%v)", val1, val2)
}
return uint32(val1), uint32(val2), nil
default:
Expand Down
2 changes: 1 addition & 1 deletion pkg/bitmap/format_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ func TestParse(t *testing.T) {
{"1,2-4,5,16", []uint32{1, 2, 3, 4, 5, 16}, false},
{"abc", []uint32{}, true},
{"1,3-2,4", []uint32{}, true},
{"1,3-3,4", []uint32{}, true},
{"1,3-3,4", []uint32{1, 3, 4}, false},
{"1,2,3\000,4", []uint32{1, 2, 3}, false},
{"1,2,3\n,4", []uint32{1, 2, 3}, false},
}
Expand Down
Loading