tcpip: update Endpoint.Write documentation - #14161
Closed
Rajkaran-122 wants to merge 1 commit into
Closed
Conversation
The Write method signature changed from accepting SlicePayload to
accepting Payloader, but the documentation still referenced the old
SlicePayload{data} syntax. Update the documentation to reflect the
current signature and clarify the ownership transfer semantics.
Fixes google#6024.
EtiennePerot
approved these changes
Aug 18, 2026
EtiennePerot
left a comment
Collaborator
There was a problem hiding this comment.
This is a correct but low-value PR. In the future please limit PRs to higher-value changes.
Collaborator
|
Actually incorrect. LLM review:
Future PRs of this kind will not be accepted, even if they use correct wording, because they waste more human review time and attention than they are worth. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6024.
The Write method signature changed from accepting SlicePayload to
accepting Payloader, but the documentation still referenced the old
SlicePayload{data} syntax. Update the documentation to reflect the
current signature and clarify the ownership transfer semantics.
Testing
Scope
This change is limited to updating documentation only. No code logic or behavior changes are made. The ownership transfer semantics remain the same as documented in the issue comments by maintainers.