Skip to content

runsc gofer: Remove /proc unmounter and unmount in-process instead. - #14136

Open
EtiennePerot wants to merge 1 commit into
google:masterfrom
EtiennePerot:gofer-no-proc-unmounter
Open

runsc gofer: Remove /proc unmounter and unmount in-process instead.#14136
EtiennePerot wants to merge 1 commit into
google:masterfrom
EtiennePerot:gofer-no-proc-unmounter

Conversation

@EtiennePerot

Copy link
Copy Markdown
Collaborator

Saves about 3ms on the gofer hot path.

Benchmarks:

                 │     base     │                  new                  │
                 │    sec/op    │    sec/op     vs base                 │
  RunscDo           75.78m ± 3%   73.06m ±  2%   -3.59% (p=0.012 n=200)
  GoferInit        10.403m ± 5%   7.364m ± 13%  -29.21% (p=0.000 n=25)

Saves about 3ms on the gofer hot path.

Benchmarks:

```
                 │     base     │                  new                  │
                 │    sec/op    │    sec/op     vs base                 │
  RunscDo           75.78m ± 3%   73.06m ±  2%   -3.59% (p=0.012 n=200)
  GoferInit        10.403m ± 5%   7.364m ± 13%  -29.21% (p=0.000 n=25)
```
Comment thread runsc/cmd/gofer.go
copybara-service Bot pushed a commit that referenced this pull request Aug 18, 2026
Saves about 3ms on the gofer hot path.

Benchmarks:

```
                 │     base     │                  new                  │
                 │    sec/op    │    sec/op     vs base                 │
  RunscDo           75.78m ± 3%   73.06m ±  2%   -3.59% (p=0.012 n=200)
  GoferInit        10.403m ± 5%   7.364m ± 13%  -29.21% (p=0.000 n=25)
```

FUTURE_COPYBARA_INTEGRATE_REVIEW=#14136 from EtiennePerot:gofer-no-proc-unmounter 9c7b729
PiperOrigin-RevId: 966851384
copybara-service Bot pushed a commit that referenced this pull request Aug 18, 2026
Saves about 3ms on the gofer hot path.

Benchmarks:

```
                 │     base     │                  new                  │
                 │    sec/op    │    sec/op     vs base                 │
  RunscDo           75.78m ± 3%   73.06m ±  2%   -3.59% (p=0.012 n=200)
  GoferInit        10.403m ± 5%   7.364m ± 13%  -29.21% (p=0.000 n=25)
```

FUTURE_COPYBARA_INTEGRATE_REVIEW=#14136 from EtiennePerot:gofer-no-proc-unmounter 9c7b729
PiperOrigin-RevId: 966851384
copybara-service Bot pushed a commit that referenced this pull request Aug 19, 2026
Saves about 3ms on the gofer hot path.

Benchmarks:

```
                 │     base     │                  new                  │
                 │    sec/op    │    sec/op     vs base                 │
  RunscDo           75.78m ± 3%   73.06m ±  2%   -3.59% (p=0.012 n=200)
  GoferInit        10.403m ± 5%   7.364m ± 13%  -29.21% (p=0.000 n=25)
```

FUTURE_COPYBARA_INTEGRATE_REVIEW=#14136 from EtiennePerot:gofer-no-proc-unmounter 9c7b729
PiperOrigin-RevId: 966851384
copybara-service Bot pushed a commit that referenced this pull request Aug 19, 2026
Saves about 3ms on the gofer hot path.

Benchmarks:

```
                 │     base     │                  new                  │
                 │    sec/op    │    sec/op     vs base                 │
  RunscDo           75.78m ± 3%   73.06m ±  2%   -3.59% (p=0.012 n=200)
  GoferInit        10.403m ± 5%   7.364m ± 13%  -29.21% (p=0.000 n=25)
```

FUTURE_COPYBARA_INTEGRATE_REVIEW=#14136 from EtiennePerot:gofer-no-proc-unmounter 9c7b729
PiperOrigin-RevId: 966851384
copybara-service Bot pushed a commit that referenced this pull request Aug 19, 2026
Saves about 3ms on the gofer hot path.

Benchmarks:

```
                 │     base     │                  new                  │
                 │    sec/op    │    sec/op     vs base                 │
  RunscDo           75.78m ± 3%   73.06m ±  2%   -3.59% (p=0.012 n=200)
  GoferInit        10.403m ± 5%   7.364m ± 13%  -29.21% (p=0.000 n=25)
```

FUTURE_COPYBARA_INTEGRATE_REVIEW=#14136 from EtiennePerot:gofer-no-proc-unmounter 9c7b729
PiperOrigin-RevId: 966851384
copybara-service Bot pushed a commit that referenced this pull request Aug 19, 2026
Saves about 3ms on the gofer hot path.

Benchmarks:

```
                 │     base     │                  new                  │
                 │    sec/op    │    sec/op     vs base                 │
  RunscDo           75.78m ± 3%   73.06m ±  2%   -3.59% (p=0.012 n=200)
  GoferInit        10.403m ± 5%   7.364m ± 13%  -29.21% (p=0.000 n=25)
```

FUTURE_COPYBARA_INTEGRATE_REVIEW=#14136 from EtiennePerot:gofer-no-proc-unmounter 9c7b729
PiperOrigin-RevId: 966851384
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants