Repository navigation
Make BaseEncoding.encodingStream().close() idempotent. - #8642
Closed
Divyansh151005 wants to merge 1 commit into
Closed
Divyansh151005 wants to merge 1 commit into
Divyansh151005 wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Member
|
We can't review your PR unless you sign the CLA. |
Fixes google#5284 RELNOTES=`io`: Fixed a bug in which calling `close()` more than once on a `BaseEncoding.encodingStream()` could write extra padding characters.
Divyansh151005
force-pushed
the
fix/base-encoding-close-idempotent
branch
from
October 17, 2026 15:09
bab7f45 to
162a171
Compare
Contributor
Author
|
@cgdecker Thanks for the heads-up. The CLA check was failing because of an extra co-author trailer on the commits, not my own signature. I've rewritten the commit without it (code unchanged), and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closeable.close()specifies that closing an already-closed stream must have no effect. Today, callingclose()twice on aBaseEncoding.encodingStream()can write extra padding characters on the second call.Reproduction:
Fixes #5284
Solution
Track a
closedflag on the encoding stream and return immediately from subsequentclose()calls. ResetbitBufferLengthafter flushing any remaining bits on the first close.Testing