-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added EvictingBlockingQueue implementation. Closes #3882 #5417
base: master
Are you sure you want to change the base?
Added EvictingBlockingQueue implementation. Closes #3882 #5417
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
Fixing concurrency bugs regarding Remove() and will update pull request. |
Done. Can you please review? Thanks! |
import java.util.concurrent.BlockingQueue; | ||
import java.util.concurrent.TimeUnit; | ||
import com.google.common.annotations.VisibleForTesting; | ||
import com.google.errorprone.annotations.CanIgnoreReturnValue; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- New line between static and non static.
- ASCII ordering for imports.
Also I'm new to github. Do we usually comment on style stuff?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
|
||
public final class EvictingBlockingQueue<E> extends ForwardingBlockingQueue<E> implements Serializable{ | ||
|
||
private static final long serialVersionUID = -4305601088881265868L; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://google.github.io/styleguide/javaguide.html#s5.2.4-constant-names
Constants should be uppercase snake?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The property was removed.
Any chance to get this approved finally? |
Initial commit for an EvictingBlockingQueue.
Please share your input.