Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added EvictingBlockingQueue implementation. Closes #3882 #5417

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

noamgrinch
Copy link

Initial commit for an EvictingBlockingQueue.
Please share your input.

@google-cla
Copy link

google-cla bot commented Feb 25, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Feb 25, 2021
@noamgrinch
Copy link
Author

@googlebot I signed it!

@noamgrinch
Copy link
Author

Fixing concurrency bugs regarding Remove() and will update pull request.

@noamgrinch
Copy link
Author

noamgrinch commented Feb 28, 2021

Done. Can you please review? Thanks!

import java.util.concurrent.BlockingQueue;
import java.util.concurrent.TimeUnit;
import com.google.common.annotations.VisibleForTesting;
import com.google.errorprone.annotations.CanIgnoreReturnValue;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Google style guide 3.3.3

  1. New line between static and non static.
  2. ASCII ordering for imports.

Also I'm new to github. Do we usually comment on style stuff?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.


public final class EvictingBlockingQueue<E> extends ForwardingBlockingQueue<E> implements Serializable{

private static final long serialVersionUID = -4305601088881265868L;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The property was removed.

@thhart
Copy link

thhart commented Mar 9, 2023

Any chance to get this approved finally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants