MOE Sync 2020-06-08 #3922
MOE Sync 2020-06-08 #3922
Conversation
forEach can pass calls directly to the delegate protected collection because it is a read-only operation. Fixes #3911 Fixes #3912 RELNOTES=n/a ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=314952594
RELNOTES=`collect`: Added two-element min and max methods to Comparators. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=315365436
…in(E, E, Comparator) and max(E, E, Comparator). RELNOTES=Discourage the use of Ordering.min(E, E) and max(E, E). ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=315373918
kluever
added
the
internal-sync
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
4 participants
This code has been reviewed and submitted internally. Feel free to discuss on
the PR, and we can submit follow-up changes as necessary.
Commits:
Efficient UnmodifiableMultimap forEach
forEach can pass calls directly to the delegate protected
collection because it is a read-only operation.
Fixes #3911
Fixes #3912
98a6164
Add Comparators.min/max
RELNOTES=
collect: Added two-element min and max methods to Comparators.fc7433e
Discourage Ordering.min(E, E) and max(E, E) in favor of Comparators.min(E, E, Comparator) and max(E, E, Comparator).
RELNOTES=Discourage the use of Ordering.min(E, E) and max(E, E).
8bf31e1