Fix equals when comparing two PowerSet instances with different order #3891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If two PowerSet instances are constructed from Sets with the same elements but different iteraton order, PowerSet.equals will incorrectly return false.
MrHeer
approved these changes
May 3, 2020
|
Thanks for the improvement! That certainly does look like a bug, and I appreciate the reproducing test. I'll mirror this change internally, and you should see it added back out later today or tomorrow. |
|
Cool; thank you! 😁 I'm very glad to have helped. |
Merged
nick-someone
pushed a commit
that referenced
this pull request
May 4, 2020
…are the same, but in a different iteration order. RELNOTES: Fix issue where PowerSet.equals(PowerSet) would erroneously return false if the PowerSet's underlying Sets were equal, but in a different iteration order. Fixes #3891, #3890 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=309745434
nick-someone
pushed a commit
that referenced
this pull request
May 4, 2020
…are the same, but in a different iteration order. RELNOTES: Fix issue where PowerSet.equals(PowerSet) would erroneously return false if the PowerSet's underlying Sets were equal, but in a different iteration order. Fixes #3891, #3890 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=309745434
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3890