Filter out java.lang.Object from checked types and fallback to getMethods() if getDeclaredMethods() causes SecurityException.

[vrozov]

fixes #3858 and #3859

[ljacqu]

Just as a viewer passing by—

Conceptually: if you fall back to getMethods it's a little excessive to call it for every supertype since you get all parent methods immediately. Might be worth checking first whether you can call getDeclaredMethods and if not to use clazz.getMethods as your sole source of methods.

Stylistically: I find the two streams within each other to be really awkward. The previous version with regular loops was much more clear IMHO. Streams work out nicely when you have a small filter-and-transform thing going on but nesting them makes it difficult to remember where one is located.
I also find it awkward that the Set identifiers is just used for a uniqueness check (filter on L205) vs. how the map was used to determine the results in the end. Also just for reference the filter call on L192 that always returns true could be turned into a peek.

[vrozov]

Any plan to pull this into a release?

[vrozov]

@netdpb the PR is open for almost a year, are there any plan to merge it?