-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UnsignedShort patch as pull request #2100
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
Can you give us more details about what specific UnsignedShorts methods you would personally need? Note that Java 8 added some unsigned type support, so I'm not sure we want to further expand Guava in this area. |
FWIW this would be very useful. Java 8 offers limited support for unsigned types, and in particular it does not offer UnsignedShorts.checkedCast() (it only offers widening conversions). That happens to be my use case. |
@lowasser Any outstanding issues preventing this addition? |
@lowasser Could this be merged? |
This is a very, very old merge request. I don't see any chance this will be merged anytime, to be honest :-( |
@jschneider What's the hold up? Lack of demand? Something else? |
@cowwoc I have absolutely no idea. But the pull request has been created in 2015, so.... |
I see that the branch is able to be merged and the tests are all included. Let's try to get attention to it and get it merged anyway? It's a good patch for those of us writing clients that interact with binary data protocols. For brevity it doesn't make sense to leave short types excluded. |
@cpovirk any reason for not merging this PR? |
Maybe this is easier to get worked on?
applied patch from https://codereview.appspot.com/5271042/
Beware: It seems that there have been some refactorings to UnsignedInteger/UnsignedInts that are probably not reflected within the UnsignedShort(s) classes.