Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnsignedShort patch as pull request #2100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jschneider
Copy link

Maybe this is easier to get worked on?
applied patch from https://codereview.appspot.com/5271042/

Beware: It seems that there have been some refactorings to UnsignedInteger/UnsignedInts that are probably not reflected within the UnsignedShort(s) classes.

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@jschneider jschneider mentioned this pull request Jul 8, 2015
@jschneider
Copy link
Author

I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Sep 1, 2015
@lowasser
Copy link
Contributor

lowasser commented Sep 1, 2015

Can you give us more details about what specific UnsignedShorts methods you would personally need?

Note that Java 8 added some unsigned type support, so I'm not sure we want to further expand Guava in this area.

@travisdowns
Copy link

FWIW this would be very useful. Java 8 offers limited support for unsigned types, and in particular it does not offer UnsignedShorts.checkedCast() (it only offers widening conversions). That happens to be my use case.

@cowwoc
Copy link

cowwoc commented May 8, 2017

@lowasser Any outstanding issues preventing this addition?

@czee
Copy link

czee commented Jan 10, 2022

@lowasser Could this be merged?

@jschneider
Copy link
Author

This is a very, very old merge request. I don't see any chance this will be merged anytime, to be honest :-(

@cowwoc
Copy link

cowwoc commented Jan 10, 2022

@jschneider What's the hold up? Lack of demand? Something else?

@jschneider
Copy link
Author

@cowwoc I have absolutely no idea. But the pull request has been created in 2015, so....

@czee
Copy link

czee commented Jan 11, 2022

I see that the branch is able to be merged and the tests are all included. Let's try to get attention to it and get it merged anyway? It's a good patch for those of us writing clients that interact with binary data protocols. For brevity it doesn't make sense to leave short types excluded.

@rastov
Copy link

rastov commented Feb 28, 2022

@cpovirk any reason for not merging this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants