Reverse toString parsing for InetAddresses.

[rhuffy]

InetAddress.toString() outputs a string in the format <hostname>/<address>. I have use cases where I need to convert this string back to an Inet4Address or Inet6Address, which I think would be useful to include in Guava's InetAddresses class.

The code I'm using currently looks like this:

  public static InetAddress forHostnameAddressString(String hostAndAddr) throws UnknownHostException {
    checkNotNull(hostAndAddr);

    if (hostAndAddr.contains("/")) {
      String[] parts = hostAndAddr.split("/", 2);
      String host = parts[0];
      String addr = parts[1];
      InetAddress inetAddress = InetAddresses.forString(addr);

      if (inetAddress instanceof Inet4Address) {
        return Inet4Address.getByAddress(host, inetAddress.getAddress());
      } else if (inetAddress instanceof Inet6Address) {
        return Inet6Address.getByAddress(host, inetAddress.getAddress(), ((Inet6Address) inetAddress).getScopeId());
      } else {
        throw new IllegalStateException("InetAddress must be an instance of Inet4Address or Inet6Address");
      }
    } else {
      return InetAddresses.forString(hostAndAddr);
    }
  }

[netdpb]

Are these cases in which it's not guaranteed that the string was generated from InetAddress.toString()? Because those always have the "/".

[Shin0017]

Hi netdpb! May I take this issue?

[netdpb]

Hi @Shin0017. Thanks for asking! Generally we don't want to accept new APIs until we have some more discussion of the requirements, the use cases, and specifically the API. I haven't heard back from @rhuffy about my question yet. Do you have any thoughts here?

[Shin0017]

Thanks for your response!

If the string does not contain '/', then this string was not generated from InetAddress.toString(). Otherwise, individually check the legality of each part generated by split() to ensure that this string can be generated by some InetAddress.toString(). If the verification confirms its legitimacy, return the corresponding Inet4Address or Inet6Address.

[netdpb]

Thanks.

We still have questions about the usefulness of this feature. How many people need such an API? (We have seen no need for it within Google.) If you're serializing InetAddress. why is the toString() the right serialization format?

Another question for @rhuffy: The code snippet you provided passes the addr part to InetAddresses.forString(String) and uses the parsed scope ID portion—but that method is documented to drop any such scope ID from the string. Is the scope ID part important? If not, why not? If so, I think it would be the first example of an API in InetAddresses that cares about the scope ID.

[blackdurumi]

Hi @netdpb, I'd like to work on this issue, too.

I think we can create a new static method that does the exact opposite of toString(), and just ignore the other cases(let's throw an exception).
How do you think?

[netdpb]

Hi @blackdurumi. Until we have a better sense of why such a feature would be actually useful to people, we won't accept it as an API addition. Additionally, there are questions about whether it's even possible (or desirable) to round-trip the scope ID.

[nehajha2804]

Hello, i am a beginner will you please allow me to contribute and try to fix

[netdpb]

I think I'll close this issue, since no one has given an argument for why such an API is a good one to have.

This doesn't have to be a final decision. Feel free to comment here with new information.

[nehajha2804]

Hello, No worries. Thank you for the reply. Since you have closed this issue, is there any other part where I could contribute? I am looking for some good work.

…

On Mon, Dec 9, 2024 at 9:46 PM David P. Baker ***@***.***> wrote: I think I'll close this issue, since no one has given an argument for why such an API is a good one to have. This doesn't have to be a final decision. Feel free to comment here with new information. — Reply to this email directly, view it on GitHub <#6713 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BI5WNLTJIX32I5FPXLGALB32EW667AVCNFSM6AAAAABTGM7CIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRYGUZTQOBTGE> . You are receiving this because you commented.Message ID: ***@***.***>