Adjust Troubleshooting Guide ProGuard / R8 section #2844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marcono1234
commented
Apr 14, 2025
| - You should only ever set the property to `"true"`, but never to any other value or manually clear it. Otherwise this might counteract any libraries you are using which might have deliberately set the system property because they rely on its behavior. | ||
|
|
||
| ## ProGuard / R8 | ||
| ## <a id="proguard-r8"></a> ProGuard / R8 |
Contributor
Author
There was a problem hiding this comment.
Used a custom anchor here for consistency with the other ones. If we really want to change something about these anchors, then it would be better to do it for all and not just for a single one.
Within GitHub these custom anchors seem to work fine, and also within IntelliJ they work to some extent. See #2843 (comment).
eamonnmcmanus
approved these changes
Apr 14, 2025
Member
|
Thanks! |
This was referenced Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #2843