Remove old code style configs #2717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gson now uses spotless (with google-java-format) for formatting, so these configs are not that useful anymore. Additionally, users can obtain IDE formatting configs from https://github.com/google/styleguide, or use https://github.com/google/google-java-format integrations. This is probably better than duplicating the IDE configurations here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Gson now uses Spotless (with google-java-format) for formatting, so these configs are not that useful anymore.
Additionally, users can obtain IDE formatting configs from https://github.com/google/styleguide, or use https://github.com/google/google-java-format integrations.
This is probably better than duplicating the IDE configurations here.