Validate GsonBuilder.setDateFormat style arguments & extend tests
#2545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`DateFormat` validates these arguments as well, but it is currently not documented, see https://bugs.openjdk.org/browse/JDK-8319628. Also moves the other tests for `setDateFormat(String)` from DefaultTypeAdaptersTest to GsonBuilderTest.
|
Unicornsavior42
…On Sat, Nov 18, 2023, 5:10 PM Éamonn McManus ***@***.***> wrote:
Merged #2545 <#2545> into main.
—
Reply to this email directly, view it on GitHub
<#2545 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4QFN7QOFQJDLNKR6YU2JR3YFEW55AVCNFSM6AAAAAA7RHJ4MCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGAYDENJWGI4TMMI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Marcono1234
deleted the
marcono1234/GsonBuilder-setDateFormat-style-validation
branch
Contributor
Author
|
As side note: Even though this extends the tests, it does not cover all use cases; #1529 is most likely still unresolved. |
tibor-universe
pushed a commit
to getuniverse/gson
that referenced
this pull request
Sep 14, 2024
…oogle#2545) `DateFormat` validates these arguments as well, but it is currently not documented, see https://bugs.openjdk.org/browse/JDK-8319628. Also moves the other tests for `setDateFormat(String)` from DefaultTypeAdaptersTest to GsonBuilderTest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Validate
GsonBuilder.setDateFormatstyle arguments & extend testsDescription
As side note:
DateFormatvalidates these arguments as well, but it is currently not documented, see https://bugs.openjdk.org/browse/JDK-8319628.Also moves the other tests for
setDateFormat(String)fromDefaultTypeAdaptersTesttoGsonBuilderTestbecause they just test functionality ofGsonBuilder.setDateFormatwould testing any type adapter functionality.(Acts a bit as follow-up for #2538.)
Checklist
This is automatically checked by
mvn verify, but can also be checked on its own usingmvn spotless:check.Style violations can be fixed using
mvn spotless:apply; this can be done in a separate commit to verify that it did not cause undesired changes.null@since $next-version$(
$next-version$is a special placeholder which is automatically replaced during release)TestCase)mvn clean verify javadoc:jarpasses without errors