Simplify JsonReader #2221
Closed
Simplify JsonReader #2221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it can be modified here. What's your opinion?
ThirdGoddess
changed the title
Marcono1234
reviewed
Oct 12, 2022
Contributor
Marcono1234
left a comment
Marcono1234
left a comment
There was a problem hiding this comment.
Looks good, but please edit the title of your pull request to be more meaningful, for example: "Simplify JsonReader.peekNumber()"
(or similar)
ThirdGoddess
changed the title
ThirdGoddess
requested review from
Marcono1234 and
eamonnmcmanus
and removed request for
Marcono1234 and
eamonnmcmanus
Contributor
|
@ThirdGoddess, do you want to include the changes we mentioned in the review thread above? |
Merged
Contributor
|
This change was implemented now by #2282, therefore I am going to close your pull request. Thank you nontheless for your work on this! (Though I guess the condition in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it can be modified here. What's your opinion?