Skip to content

Issue 1242: Printing Gson version when throwing AssertionError and Il… #1321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2018

Conversation

inder123
Copy link
Collaborator

…legalArgumentException

On some versions of Android (probably on some variants of the popular Samsung S4 phone), an older version of Gson is suspected to be bundled in, and gets picked up from the system classpath.
For those versions, the applications that include the latest Gson fail unexpectedly. This debug print will help confirm this issue.

…legalArgumentException

On some versions of Android (probably on some variants of the popular Samsung S4 phone), an older version of Gson is suspected to be bundled in, and gets picked up from the system classpath.
For those versions, the applications that include the latest Gson fail unexpectedly. This debug print will help confirm this issue.
@inder123
Copy link
Collaborator Author

@swankjesse @JakeWharton @joel-leitch
I would like to include this PR into the new build 2.8.5. This will help us isolate problems in specific versions of Gson.

@inder123 inder123 merged commit d84e26d into master May 17, 2018
@inder123 inder123 deleted the 1242 branch May 17, 2018 16:41
FredricMei pushed a commit to orientsec/gson that referenced this pull request Feb 11, 2019
…legalArgumentException (google#1321)

On some versions of Android (probably on some variants of the popular Samsung S4 phone), an older version of Gson is suspected to be bundled in, and gets picked up from the system classpath.
For those versions, the applications that include the latest Gson fail unexpectedly. This debug print will help confirm this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants