Gson default value handling #1006
Conversation
jainsahab
changed the title
jainsahab
changed the title
|
@inder123 @JakeWharton any feedback on this PR? |
This comment has been minimized.
This comment has been minimized.
|
Wondering the status of this PR because I could really use this in my project right now |
| @@ -16,24 +16,6 @@ | |||
|
|
|||
| package com.google.gson; | |||
|
|
|||
| import java.io.EOFException; | |||
There was a problem hiding this comment.
It would be good, if possible, to not reorder imports since it makes spotting imports added by accident and similar rather difficult.
| @@ -250,7 +252,8 @@ public Gson() { | |||
| factories.add(jsonAdapterFactory); | |||
| factories.add(TypeAdapters.ENUM_FACTORY); | |||
| factories.add(new ReflectiveTypeAdapterFactory( | |||
| constructorConstructor, fieldNamingStrategy, excluder, jsonAdapterFactory)); | |||
| constructorConstructor, fieldNamingStrategy, excluder, jsonAdapterFactory, | |||
| this.missingFieldHandlingStrategy)); | |||
There was a problem hiding this comment.
| this.missingFieldHandlingStrategy)); | |
| missingFieldHandlingStrategy)); |
To be consistent maybe don't qualify using this here
| @@ -16,23 +16,24 @@ | |||
|
|
|||
| package com.google.gson; | |||
|
|
|||
| import com.google.gson.internal.$Gson$Preconditions; | |||
There was a problem hiding this comment.
Same as above, if possible don't reorder imports
| private MissingFieldHandlingStrategy missingFieldHandlingStrategy = new MissingFieldHandlingStrategy() { | ||
| @Override | ||
| public Object handle(TypeToken typeToken, String fieldName) { | ||
| return defaultValues.get(typeToken.getRawType()); |
There was a problem hiding this comment.
| return defaultValues.get(typeToken.getRawType()); | |
| return defaultValues.get(typeToken.getRawType()); |
| * Configure Gson to register a default value for a type given which will be used when Gson didn't found any field's | ||
| * value in JSON. |
There was a problem hiding this comment.
| * Configure Gson to register a default value for a type given which will be used when Gson didn't found any field's | |
| * value in JSON. | |
| * Configure Gson to register a default value for a type given which will be used when Gson didn't find a value for a | |
| * field in JSON. |
| * This strategy is implemented by the user and should be passed to | ||
| * {@link GsonBuilder#useMissingFieldHandlingStrategy(MissingFieldHandlingStrategy)} method | ||
| * so that Gson can use it. | ||
| * The {@link #handle(TypeToken, String)} is used by the Gson to determine the default value |
There was a problem hiding this comment.
Might have to format this using <p> or <br>
| * This strategy is implemented by the user and should be passed to | ||
| * {@link GsonBuilder#useMissingFieldHandlingStrategy(MissingFieldHandlingStrategy)} method | ||
| * so that Gson can use it. | ||
| * The {@link #handle(TypeToken, String)} is used by the Gson to determine the default value |
There was a problem hiding this comment.
| * The {@link #handle(TypeToken, String)} is used by the Gson to determine the default value | |
| * The {@link #handle(TypeToken, String)} is used by Gson to determine the default value |
| * @author Prateek Jain | ||
| */ | ||
| public interface MissingFieldHandlingStrategy { | ||
| Object handle(TypeToken type, String fieldName); |
There was a problem hiding this comment.
Would be good to document this method.
| Set<String> fieldNames = boundFields.keySet(); | ||
| for (String fieldName : fieldNames) { | ||
| BoundField boundField = boundFields.get(fieldName); |
There was a problem hiding this comment.
Why not iterate over boundFields.values()? Getting all keys and then getting their values seems rather complicated.
| @@ -178,27 +185,76 @@ static boolean excludeField(Field f, boolean serialize, Excluder excluder) { | |||
| } | |||
|
|
|||
| static abstract class BoundField { | |||
| boolean initialized; | |||
There was a problem hiding this comment.
Making BoundField mutable likely won't work since com.google.gson.Gson.typeTokenCache is caching adapters. So if someone tries to deserialize the same class twice (e.g. nested or in an array).
You might have to move that logic to ReflectiveTypeAdapterFactory.Adapter.read(JsonReader) instead.
resolve #1005.
this change will make Gson capable of populating default values in Java models if the corresponding nodes are missing in Json.