Wrapped url path in custom class and expose as signal from Navigation… #2267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gino-m
requested changes
Oct 15, 2025
web/src/app/components/job-list-item/job-list-item.component.ts
Outdated
Show resolved
Hide resolved
gino-m
requested changes
Nov 14, 2025
gino-m
requested changes
Nov 14, 2025
| surveyId?: string | null; | ||
| json = ''; | ||
|
|
||
| private surveyIdSignal = this.navigationService.getSurveyId(); |
Collaborator
There was a problem hiding this comment.
Re need to remove this call.
| private subscription = new Subscription(); | ||
| export class EditSurveyComponent { | ||
| private urlSignal = this.navigationService.getUrl(); | ||
| private surveyIdSignal = this.navigationService.getSurveyId(); |
| activeSurvey$: Observable<Survey>; | ||
| private subscription = new Subscription(); | ||
| export class MainPageContainerComponent { | ||
| private surveyIdSignal = this.navigationService.getSurveyId(); |
| return this.urlParamsSignal; | ||
| } | ||
|
|
||
| getSurveyId(): Signal<string | null> { |
Collaborator
There was a problem hiding this comment.
This getFooId methods should be deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1693