Skip to content

Fix GeoJSON properties order #2253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix GeoJSON properties order #2253

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0b50b86
Fix GeoJSON properties order
rfontanarosa Sep 16, 2025
676bd6a
removed wrong import
rfontanarosa Sep 16, 2025
91b19f4
Merge branch 'master' into rfontanarosa/2252/export-geojson-propertie…
rfontanarosa Sep 23, 2025
743d6ce
Merge branch 'master' into rfontanarosa/2252/export-geojson-propertie…
rfontanarosa Sep 26, 2025
4bfeeb9
sort properties
rfontanarosa Sep 26, 2025
3aaea7c
Merge branch 'master' into rfontanarosa/2252/export-geojson-propertie…
rfontanarosa Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions functions/src/export-geojson.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
*/

import * as functions from 'firebase-functions';
import {Map} from 'immutable';
import {canExport, hasOrganizerRole} from './common/auth';
import {getDatastore} from './common/context';
import {isAccessibleLoi} from './common/utils';
Expand Down Expand Up @@ -128,7 +127,7 @@ function buildFeature(loi: Pb.LocationOfInterest) {
}
return {
type: 'Feature',
properties: propertiesPbToModel(loi.properties).toObject(),
properties: propertiesPbToObject(loi.properties),
geometry: toGeoJsonGeometry(loi.geometry),
};
}
Expand All @@ -142,15 +141,15 @@ function getFileName(jobName: string | null) {
return `${fileBase}.geojson`;
}

function propertiesPbToModel(pb: {
function propertiesPbToObject(pb: {
[k: string]: Pb.LocationOfInterest.IProperty;
}): Map<string, string | number> {
}): {[k: string]: string | number} {
const properties: {[k: string]: string | number} = {};
for (const k of Object.keys(pb)) {
for (const k of Object.keys(pb).sort()) {
const v = pb[k].stringValue || pb[k].numericValue;
if (v !== null && v !== undefined) {
properties[k] = v;
}
}
return Map(properties);
return properties;
}
Loading