Add GitHub action for CI testing #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
force-pushed
the
add-gh-action
branch
4 times, most recently
from
db52fd0 to
83797e4
Compare
This extends the testing currently done in CircleCI: * run CI on macOS in addition to Linux and Windows * testing with multiple Go versions (1.12 through 1.16), not just Go 1.12 like CircleCI * checks that the code is properly gofmt'ed * checks proper module vendoring
tklauser
force-pushed
the
add-gh-action
branch
from
83797e4 to
49c3244
Compare
Contributor
Author
|
Thanks for the review @odeke-em! I'll merge this, but leave CircleCI enabled for now. Once the GitHub actions prove stable and useful we could think about dropping CircleCI. |
tklauser
added a commit
that referenced
this pull request
May 4, 2022
CircleCI tests seem to be consistently failing currently. GitHub actions introduced in #136 are providing the same coverage (and more), have been running stable for over a year and are easier to maintain. Thus, remove Circle CI integration.
tklauser
added a commit
that referenced
this pull request
May 4, 2022
CircleCI tests currently seem fail consistently. GitHub actions introduced in #136 are providing the same coverage (and more), have been running stable for over a year and are easier to maintain. Thus, remove Circle CI integration. Ref. #136 (comment)
Merged
tklauser
added a commit
that referenced
this pull request
May 4, 2022
CircleCI tests currently seem fail consistently. GitHub actions introduced in #136 are providing the same coverage (and more), have been running stable for over a year and are easier to maintain. Thus, remove Circle CI integration. Ref. #136 (comment)
tklauser
added a commit
that referenced
this pull request
May 4, 2022
CircleCI tests currently seem fail consistently. GitHub actions introduced in #136 are providing the same coverage (and more), have been running stable for over a year and are easier to maintain. Thus, remove Circle CI integration. Ref. #136 (comment)
corey0106
added a commit
to corey0106/Go_project
that referenced
this pull request
Dec 6, 2024
CircleCI tests currently seem fail consistently. GitHub actions introduced in #136 are providing the same coverage (and more), have been running stable for over a year and are easier to maintain. Thus, remove Circle CI integration. Ref. google/gops#136 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the testing currently done in CircleCI:
1.12 like CircleCI
gofmt'ed