Remove C from CMake #4878
Open
Remove C from CMake #4878
+4
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theComputeKid
changed the title
theComputeKid
force-pushed
the
remove-c
branch
from
2868a9c to
a034cbb
Compare
theComputeKid
force-pushed
the
remove-c
branch
from
a034cbb to
8a4d44a
Compare
There is no need to declare C as a needed language in cmake to build the project.
theComputeKid
force-pushed
the
remove-c
branch
from
8a4d44a to
e61a95a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to declare C as a needed language in cmake to build the project. Inspecting the compile_commands.json also indicates that everything is built with a C++ compiler. This PR removes the requirement to detect a valid C compiler on the build system. For projects that include googletest as a dependency, there are subtle reasons why we would not want to initialise a C compiler.
The comments indicate that C was only used for
find_package(Threads)but I can see no reference to it in the code so this comment must no longer be relevant. This leads me to believe it should be safe to make GoogleTest a purely CXX project.