Do constant time matching for exact match filters. #3746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reduces gtest-runner runtime with libva-utils on radeonsi by ~40%. Now we're spending 95% of CPU time in our actual tests. |
IYP-Programer-Yeah
force-pushed
the
use-constant-time-lookup-for-exact-match
branch
from
91f1510 to
2eadda6
Compare
dinord
reviewed
Feb 4, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use O(1) look up for patterns that are exact names of the tests. This issue arose from #3614 but I am not sure if it is something that the maintainers would want in the library.