Suppress unused-value warning

densamoilov · densamoilov · commit 035a101b62b1 · 2021-11-16T19:07:19.000-08:00
When _DEBUG is not defined the _CrtSetDbgFlag turns into ((int)0),
which causes unused-value warning for clang.
diff --git a/googletest/src/gtest-port.cc b/googletest/src/gtest-port.cc
@@ -377,12 +377,12 @@ class MemoryIsNotDeallocated
     old_crtdbg_flag_ = _CrtSetDbgFlag(_CRTDBG_REPORT_FLAG);
     // Set heap allocation block type to _IGNORE_BLOCK so that MS debug CRT
     // doesn't report mem leak if there's no matching deallocation.
-    _CrtSetDbgFlag(old_crtdbg_flag_ & ~_CRTDBG_ALLOC_MEM_DF);
+    (void)_CrtSetDbgFlag(old_crtdbg_flag_ & ~_CRTDBG_ALLOC_MEM_DF);
   }
 
   ~MemoryIsNotDeallocated() {
     // Restore the original _CRTDBG_ALLOC_MEM_DF flag
-    _CrtSetDbgFlag(old_crtdbg_flag_);
+    (void)_CrtSetDbgFlag(old_crtdbg_flag_);
   }
 
  private:

Original file line number	Diff line number	Diff line change
`@@ -377,12 +377,12 @@ class MemoryIsNotDeallocated`
`377`	`377`	`old_crtdbg_flag_ = _CrtSetDbgFlag(_CRTDBG_REPORT_FLAG);`
`378`	`378`	`// Set heap allocation block type to _IGNORE_BLOCK so that MS debug CRT`
`379`	`379`	`// doesn't report mem leak if there's no matching deallocation.`
`380`		`- _CrtSetDbgFlag(old_crtdbg_flag_ & ~_CRTDBG_ALLOC_MEM_DF);`
	`380`	`+ (void)_CrtSetDbgFlag(old_crtdbg_flag_ & ~_CRTDBG_ALLOC_MEM_DF);`
`381`	`381`	`}`
`382`	`382`
`383`	`383`	`~MemoryIsNotDeallocated() {`
`384`	`384`	`// Restore the original _CRTDBG_ALLOC_MEM_DF flag`
`385`		`- _CrtSetDbgFlag(old_crtdbg_flag_);`
	`385`	`+ (void)_CrtSetDbgFlag(old_crtdbg_flag_);`
`386`	`386`	`}`
`387`	`387`
`388`	`388`	`private:`