Fix the parsing logic of matches_pattern! to support _ at the top level in top-level structs.
#627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
bot
force-pushed
the
test_748656817
branch
from
b1dee66 to
b885b37
Compare
copybara-service
bot
changed the title
matches_pattern! to properly support enums like Option. Previously, the pattern Some(_) would be parsed as None. Now the Some variant with wildcard will be parsed correctly.matches_pattern! to support _ at the top level in top-level structs.
copybara-service
bot
force-pushed
the
test_748656817
branch
6 times, most recently
from
dcb345e to
fd44fb2
Compare
… level in top-level structs. In the current parsing logic, the `_` field in pattern `Some(_)` is parsed as `None`, and as a result no FieldMatcher is generated, and the internal `is()` matcher only evaluates the innerMatcher(the field_matcher). We add `pattern_only()` matcher for the case when field_matcher is empty and skip the `is()` wrapping. Toward #626 PiperOrigin-RevId: 755284260
copybara-service
bot
force-pushed
the
test_748656817
branch
from
fd44fb2 to
3a977ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the parsing logic of
matches_pattern!to support_at the top level in top-level structs.In the current parsing logic, the
_field in patternSome(_)is parsed asNone, and as a result no FieldMatcher is generated, and the internalis()matcher only evaluates the innerMatcher(the field_matcher).We add
pattern_only()matcher for the case when field_matcher is empty and skip theis()wrapping.Toward #626