Skip to content

Java 14 switch expressions with many values are badly formatted #540

Closed
@abrudin

Description

@abrudin

When having many values covered by the same case, google-java-format does a terrible job formatting the code. Example:

public class GoogleJavaFormatFail {
  public String myMethod(final TestEnum testEnum) {
    return switch (testEnum) {
      case SOME_RATHER_LONG_NAME_1, SOME_RATHER_LONG_NAME_2, SOME_RATHER_LONG_NAME_3, SOME_RATHER_LONG_NAME_4, SOME_RATHER_LONG_NAME_5, SOME_RATHER_LONG_NAME_6, SOME_RATHER_LONG_NAME_7 -> "less than"
                                                                                                                                                                                                + " number"
                                                                                                                                                                                                + " 7";
      case SOME_RATHER_LONG_NAME_8 -> "number 8";
    };
  }

  public enum TestEnum {
    SOME_RATHER_LONG_NAME_1,
    SOME_RATHER_LONG_NAME_2,
    SOME_RATHER_LONG_NAME_3,
    SOME_RATHER_LONG_NAME_4,
    SOME_RATHER_LONG_NAME_5,
    SOME_RATHER_LONG_NAME_6,
    SOME_RATHER_LONG_NAME_7,
    SOME_RATHER_LONG_NAME_8
  }
}

This is a little sad, as the new switch statements are awesome for compile time type safety (make sure no case is missed).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions