Remove VerifyAttestation dependency on SNP/TDX #523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, VerifyAttestation required passing a SNP or TDX attestation when it detected the appropriate NonHostInfo event in the UEFI event log. This introduces a weak verification requirement that gives no guarantees in the resulting claim that the vTPM and SNP/TDX devices are actually on the same machine. Fixes google#500 and google#504.
jkl73
approved these changes
Jan 22, 2025
alexmwu
added a commit
to alexmwu/go-tpm-tools
that referenced
this pull request
Mar 5, 2025
This was removed in google#523, and we need to have this supported for the next release of gotpm until we support separate commands for SNP/TDX verification.
alexmwu
added a commit
to alexmwu/go-tpm-tools
that referenced
this pull request
Mar 5, 2025
This was removed in google#523, and we need to have this supported for the next release of gotpm until we support separate commands for SNP/TDX verification.
alexmwu
added a commit
to alexmwu/go-tpm-tools
that referenced
this pull request
Mar 5, 2025
This was removed in google#523, and we need to have this supported for the next release of gotpm until we support separate commands for SNP/TDX verification.
alexmwu
added a commit
to alexmwu/go-tpm-tools
that referenced
this pull request
Mar 5, 2025
This was removed in google#523, and we need to have this supported for the next release of gotpm until we support separate commands for SNP/TDX verification.
alexmwu
added a commit
to alexmwu/go-tpm-tools
that referenced
this pull request
Mar 5, 2025
This was removed in google#523, and we need to have this supported for the next release of gotpm until we support separate commands for SNP/TDX verification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, VerifyAttestation required passing a SNP or TDX attestation when it detected the appropriate NonHostInfo event in the UEFI event log. This introduces a weak verification requirement that gives no guarantees in the resulting claim that the vTPM and SNP/TDX devices are actually on the same machine.
Fixes #500. We still need to remove the client auto collection of SNP/TDX attestation (#504), but that is a bit more work since we also need to update the gotpm CLI to include SNP and TDX attestation collection.
Internal: see go/refactor-gtt