Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use confidentialcomputing api v1.6.0 to send TDX attestation #477

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

yawangwang
Copy link
Collaborator

This PR introduces the following changes:

  • Convert tdx quoteV4 proto from go-tdx-guest repo to API protos such that new confidentialcomputing client library can understand.

@yawangwang yawangwang force-pushed the send_TDQuote_attestation branch from e4ee321 to 06155b0 Compare August 19, 2024 20:02
@yawangwang yawangwang changed the title Use confidentialcomputing api v1.6.0 to send SEVSNP attestation Use confidentialcomputing api v1.6.0 to send TDX attestation Aug 19, 2024
@yawangwang yawangwang force-pushed the send_TDQuote_attestation branch from 06155b0 to 513ff9f Compare August 19, 2024 20:08
t.Fatalf("could not write header %d: %v", i, err)
}
copy(result.table[headers[i].Offset:], cert)
}
return result
}

func TestConvertTDXProtoToREST(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a nil input check as well

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@yawangwang yawangwang force-pushed the send_TDQuote_attestation branch from 513ff9f to 6eb5cda Compare August 29, 2024 00:20
@yawangwang yawangwang force-pushed the send_TDQuote_attestation branch from 6eb5cda to 02b5e07 Compare August 29, 2024 16:04
@yawangwang
Copy link
Collaborator Author

/gcbrun

@yawangwang yawangwang merged commit 7c53d6c into google:main Sep 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants