Cleanup Template and Keys code #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes it more clear _why_ we set our flags the way we do. It also makes it easier to later add in ECC-based keys. This also fixes keys.go to: - avoid a potential nullptr dereference - use the Key() and Name() methods from go-tpm - stop decoding the creationData/tickets, as we don't care about them
twitchy-jsonp
approved these changes
Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it more clear why we set our flags the way we do.
It also makes it easier to later add in ECC-based keys.
This also fixes keys.go to:
@twitchy-jsonp we set the
noDAflag for our SRK (to not conflict with what Microsoft does), and we don't set this flag for our AIK. go-attestation seems to do the opposite. I feel like whatever we do here should be the same for both.Tests pass, and manual runs of
gotpm pubkeyconfirm the generated public keys are still the same.Note: depends on google/go-tpm#116