Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI Go Version to 1.19 (and other formatting nits) #241

Merged
merged 7 commits into from
Aug 30, 2022
Merged

Conversation

josephlr
Copy link
Member

@josephlr josephlr commented Aug 30, 2022

By upgrading our default GI version to Go 1.19, we now catch more lints/nits than we did before. To make the linter happy we:

  • Remove uses of the ioutil library
  • Add a package comment for the cmd/main package
  • Fix comment formatting in attest.proto (which also causes the generated .pb.go to change whitespace).
  • Run gofmt over the entire tree (which makes some changes, but only whitespace changes).

This reduces the patches we need when importing into google3

Signed-off-by: Joe Richey joerichey@google.com

@josephlr josephlr force-pushed the fmt branch 5 times, most recently from 288ec44 to c75675a Compare August 30, 2022 18:38
cmd/gotpm/main.go Outdated Show resolved Hide resolved
This package has been deprecated since 1.16

Signed-off-by: Joe Richey <joerichey@google.com>
The google3 importing tool complains about this

Signed-off-by: Joe Richey <joerichey@google.com>
Signed-off-by: Joe Richey <joerichey@google.com>
- Upgrade protoc
- Upgrade golang
- Update golangci-lint
- Increase timeout for golangci-lint

Signed-off-by: Joe Richey <joerichey@google.com>
@josephlr josephlr changed the title Fixup proto formatting and package comments. Update CI Go Version to 1.19 (and other formatting nits) Aug 30, 2022
Signed-off-by: Joe Richey <joerichey@google.com>
@josephlr
Copy link
Member Author

Also the commit history here is useful, so be sure to "merge" instead of "squash/rebase"

.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
Signed-off-by: Joe Richey <joerichey@google.com>
Signed-off-by: Joe Richey <joerichey@google.com>
@josephlr josephlr merged commit 8361903 into master Aug 30, 2022
@josephlr josephlr deleted the fmt branch August 30, 2022 21:52
alexmwu added a commit to alexmwu/go-tpm-tools that referenced this pull request Dec 16, 2022
Breaking Changes:

New Features:
Add IsHardened in launch spec: google#244
Add container logging redirect policy: google#249
Add SEV-SNP attestation support: google#240
Integrity-protect stateful partition on CS image: google#251
Retry launcher OIDC token refresh with backoff: google#261
Change restart policy behavior to reboot: google#260
Add ability to GetGCEInstanceInfo from a certificate: google#267

Bug Fixes:
COS event log: require CEL events to use PCR13, add a launch separator, and don't skip unknown events: google#246
Measure LaunchSeparator event: google#247
Skip unallocated PCR selections when reading all PCRs: google#258
Remove gRPC client and use of insecure credentials: google#262
Fix server.VerifyAttestation proto merging(google#263) and defer of os.Exit(google#264): google#265

Other Changes:
Add fake verifier client: google#234
Update CI Go Version to 1.19: google#241
Add launcher integration testing support: google#255
Test multi-writer PD creation disabled: google#256
Update go-sev-guest dependency to v0.2.6: google#259
Change OIDC retry policy to hourly and add jitter to refresh time: google#266
Add wrapper cloudbuild workflow to trigger image build and testing: google#269
@alexmwu alexmwu mentioned this pull request Dec 16, 2022
alexmwu added a commit that referenced this pull request Dec 16, 2022
Breaking Changes:

New Features:
Add IsHardened in launch spec: #244
Add container logging redirect policy: #249
Add SEV-SNP attestation support: #240
Integrity-protect stateful partition on CS image: #251
Retry launcher OIDC token refresh with backoff: #261
Change restart policy behavior to reboot: #260
Add ability to GetGCEInstanceInfo from a certificate: #267

Bug Fixes:
COS event log: require CEL events to use PCR13, add a launch separator, and don't skip unknown events: #246
Measure LaunchSeparator event: #247
Skip unallocated PCR selections when reading all PCRs: #258
Remove gRPC client and use of insecure credentials: #262
Fix server.VerifyAttestation proto merging(#263) and defer of os.Exit(#264): #265

Other Changes:
Add fake verifier client: #234
Update CI Go Version to 1.19: #241
Add launcher integration testing support: #255
Test multi-writer PD creation disabled: #256
Update go-sev-guest dependency to v0.2.6: #259
Change OIDC retry policy to hourly and add jitter to refresh time: #266
Add wrapper cloudbuild workflow to trigger image build and testing: #269
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants