Introduce CheckedClose #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests can now enforce error checking on tpm close. Tests can now fail if they leak TPM Handles. Introducting this actually found a bug in tpm2tools.TestHandles. This bug has been fixed to properly clear the handles.
Closed
twitchy-jsonp
approved these changes
Jun 10, 2019
stevenrutherford
approved these changes
Jun 15, 2019
josephlr
pushed a commit
to josephlr/go-tpm-tools
that referenced
this pull request
Jul 3, 2019
Remove SMAC.c from make files for fTPM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off of #15, but we make the helper public so that the
cmdtests will also be able to use it.Tests can now enforce error checking on tpm close.
Tests can now fail if they leak TPM Handles.
Introducing this actually found a bug in tpm2tools.TestHandles. This bug has been fixed to properly clear the handles.
We also fixed an issue in NewKey that was sometimes not clearing a key.