Chore: import golang golden overrides from cpp-jsonnet #845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the go-jsonnet golden output overrides should be kept here in the go-jsonnet repo. The older override mechanism (in which the cpp-jsonnet repo has golden files for Golang ending in .golang) will be removed.
|
The golend is go-jsonnet is not named as the golden in cpp-jsonnet, I suggest we keep it the same as cpp-jsonnet, then every *.jsonnet will have a *.jsonnet.golden |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the go-jsonnet golden output overrides should be kept here in the go-jsonnet repo. The older override mechanism (in which the cpp-jsonnet repo has golden files for Golang ending in .golang) will be removed.