go-jsonnet windows version is not compatible with grafonnet

[ACCRT]

Until v0.20.0, go-jsonnet windows x86-64 does not support blank line within |||. e.g.

annotation.libsonnet

  '#withAnnotations':
    d.func.new(
      |||
        `withAnnotations` adds an array of annotations to a dashboard.

        This function appends passed data to existing values
      |||,
      args=[d.arg('value', d.T.array)]
    ),

will result in Text block not terminated with |||

This makes it imcompatible with grafonnet.

It seems this problem has been raised long time ago, but it seems still a problem on windows.
Allow empty lines in multi-line blocks

[johnbartholomew]

Interesting... I guess this is a problem with CR+LF line endings. I can't think of any other reason it would behave like that.

I don't have a Windows machine easily available to check on, but I can reproduce it by giving jsonnet input with CR+LF line endings on Linux:

❯ printf '{"test":\n   |||\n      Hello\n\n      World\n   |||,\n}\n' | ./jsonnet -
{
   "test": "Hello\n\nWorld\n"
}

❯ printf '{"test":\r\n   |||\r\n      Hello\r\n\r\n      World\r\n   |||,\r\n}\r\n' | ./jsonnet -
<stdin>:2:4 Text block not terminated with |||

   |||

[johnbartholomew]

C++ and go-jsonnet behaviour seems to be the same on this.

Probably incorrect.

[johnbartholomew]

Ok I suspect that actually C++ jsonnet and go-jsonnet are behaving differently because although they have similar code (both only looking for \n not \r\n), C++ opens the file in "text mode" which (on Windows, but not on Linux/Unix) will normalise \r\n to just \n, whereas Go just reads input files as binary ("text mode" is a C and C++ library concept and I don't think it even exists in Go).

I can't actually be sure without testing on Windows though (which I can't do very easily).

I think fixing this properly (making both implementations behave consistently with each other and behave consistently across platforms) probably requires:

1. Updating all the lexing/input scanning code to recognise \r\n and handle it appropriately as a single line terminator. (Not very difficult but it touches several places in the code)
2. Update C++ jsonnet to read in binary mode for consistency with Go jsonnet. (Basically trivial).