std.manifestJsonEx breaking change in master

[squat]

Hi 👋 In previos versions of go-jsonnet, up to and including v0.17.0, std.manifestJsonEx accepted an array for the value parameter. As of master, passing an array causes jsonnet to throw an error a la:

RUNTIME ERROR: Unexpected type array, expected object

This seems like a breaking change in the standard library, however I could not find any references to this in the commits between the v0.17.0 tag and tip of master or any release notes. Is this known and expected behavior? If so, it would be great to have this documented somewhere so that users can expect to migrate their code.

[squat]

I bisected the changes and it seems that commit 7d3bda3 introduces this behavior here: 7d3bda3#diff-36bd23df839b5a1f32fa23bc561f87df1cb83820ebb8588dd652c3fb9e840484R1215

[sbarzowski]

This is a serious bug. I should have noticed this and I'm a bit surprised that our tests didn't catch this. Many thanks for reporting this!

The fix is probably trivial. It looks like it's enough to pass the value from arguments[0] directly to aux instead of forcing it to be an object.

[squat]

yes, that seems like an easy workaround 👍 happy to make a PR and add a test

[sbarzowski]

Great! Please go ahead.