request for function `std.contains`

[ghostsquad]

This is a request to have a stdlib function for contains. Right now, I'm using something like:

strContains(s, substr):: (
	std.length(std.findSubstr(substr, s)) > 0
)

But the problem is that findSubstr is doing a regex, so I need to be aware of that and escape, which is not always possible, if that value isn't hard-coded.

edit or at least that's how it reads from the documentation:

std.findSubstr(pat, str)

Returns an array that contains the indexes of all occurances of pat in str.

the use of pat being short for pattern usually meaning regex.

Is there another way to do this?

[sbarzowski]

No, it's not a regex in findSubstr. It finds all occurrences of a string pat in string str as a simple substring. The word pattern is commonly used in he context of a normal string search with exact match (especially in the books about algorithms).

I understand the confusion, though. Perhaps a more explcit phrasing is possible such as contains all indexes a which string pat occurs in string str and we may aslo want to add a few examples.

Your implementation of strContains looks correct. You can also directly compare it with the empty array instead of calling std.length. It may be potentially a good addition to the stdlib, but I remember that there were some ideas to let operator in operate on strings. Maybe we should do that instead.

[ghostsquad]

Are the docs used on the website managed in this repo, or another?

[sbarzowski]

You can find them in https://github.com/google/jsonnet/blob/v0.15.0/doc/ref/stdlib.html.

[simonrouse9461]

Any update on this?

[sbarzowski]

It's only a matter of updating the docs, the functionality exists

[CertainLach]

The funny thing is, some of jsonnet stdlib functions are implementing the same thing, e.g std.member also allows to check if string includes substring

std.member("string", "trin") == true

Maybe docs site (Or even stdlib? It would be messy, however) should have more guessable aliases for common functions?

[rowanmoul]

Maybe docs site (Or even stdlib? It would be messy, however) should have more guessable aliases for common functions?

This would be great. I never would have found std.member for strings if not for your post, as it's listed under "Arrays" on the docs site, and only mentions supporting strings in passing in the description.