[Linter]: Check for unintentional implicit +

[sbarzowski]

More details in the slack thread: https://kubernetes.slack.com/archives/C6JLE4L9X/p1528759873000379

[sparkprime]

Conclusion in that thread I think is to allow only { ... } otherwise require the +. Optionally, always require the + in the case of array or param list (where accidentally dropping the comma is a possibility).

[glerchundi]

Run into this issue and it's reeeeeally difficult to detect beforehand. In our case this went directly to the staging cluster as we're using ArgoCD for GitOps.

Any ETA for this?

[sbarzowski]

Thanks for letting us know. We don't have any specific timeline for this yet.

If we want to include this in the linter we need to first merge #325 probably (which I want to do ASAP anyway). Implementing implicit + checks may be a bit annoying, because linter runs on a desugared AST and desugaring converts all implicit +es to explicit ones (https://jsonnet.org/ref/spec.html#desugaring):.

Probably the best way to handle this is to save some additional metadata on the side, that a certain + was implicit.

Of course, if you are willing to get your hands dirty and help us with this, it will definitely speed things up.

[glerchundi]

Thanks for letting us know. We don't have any specific timeline for this yet.

Thanks for the response!

If we want to include this in the linter we need to first merge #325 probably (which I want to do ASAP anyway). Implementing implicit + checks may be a bit annoying, because linter runs on a desugared AST and desugaring converts all implicit +es to explicit ones (https://jsonnet.org/ref/spec.html#desugaring):.

Probably the best way to handle this is to save some additional metadata on the side, that a certain + was implicit.

Ok, now I have a better picture of whats going on under the hood.

Of course, if you are willing to get your hands dirty and help us with this, it will definitely speed things up.

Would love to employ my time on this as soon as I found a free slot but this is not gonna happen in the mid-term.