Skip to content

fix: Change cursor pagination to use After#3994

Merged
gmlewis merged 3 commits intogoogle:masterfrom
gmlewis:i3964-fix-cursor
Feb 11, 2026
Merged

fix: Change cursor pagination to use After#3994
gmlewis merged 3 commits intogoogle:masterfrom
gmlewis:i3964-fix-cursor

Conversation

@gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Feb 11, 2026

Fixes: #3964.

@Not-Dhananjay-Mishra pointed out in #3964 that cursor-based pagination is not working, at least on the SecurityAdvisories.ListGlobalSecurityAdvisories endpoint, and was correct that using the After field instead of the Cursor field solved the problem.

This has been tested now and without using a throttling transport, I quickly got rate-limited. 😅

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Feb 11, 2026
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.52%. Comparing base (de4dfc3) to head (6f4b31f).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3994   +/-   ##
=======================================
  Coverage   93.52%   93.52%           
=======================================
  Files         207      207           
  Lines       17591    17591           
=======================================
  Hits        16452    16452           
  Misses        938      938           
  Partials      201      201           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Feb 11, 2026
@gmlewis
Copy link
Collaborator Author

gmlewis commented Feb 11, 2026

Thank you, @alexandear! I added the integration test.
Merging.

@gmlewis gmlewis merged commit 1732098 into google:master Feb 11, 2026
8 checks passed
@gmlewis gmlewis deleted the i3964-fix-cursor branch February 11, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support native cursor-based pagination using Go 1.23 iterators

2 participants