fix: Change cursor pagination to use After#3994
Merged
gmlewis merged 3 commits intogoogle:masterfrom Feb 11, 2026
Merged
Conversation
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3994 +/- ##
=======================================
Coverage 93.52% 93.52%
=======================================
Files 207 207
Lines 17591 17591
=======================================
Hits 16452 16452
Misses 938 938
Partials 201 201 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alexandear
approved these changes
Feb 11, 2026
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Collaborator
Author
|
Thank you, @alexandear! I added the integration test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #3964.
@Not-Dhananjay-Mishra pointed out in #3964 that cursor-based pagination is not working, at least on the
SecurityAdvisories.ListGlobalSecurityAdvisoriesendpoint, and was correct that using theAfterfield instead of theCursorfield solved the problem.This has been tested now and without using a throttling transport, I quickly got rate-limited. 😅