chore(deps): Switch from gopkg.in/yaml.v3 to go.yaml.in/yaml/v3 in /tools

[scop]

The latter is a maintained fork of the former, https://github.com/yaml/go-yaml#project-status

While at it, upgrade from 3.0.1 to 3.0.4.

3.0.1 are identical, 3.0.1..3.0.2 diff between upstreams: https://gist.github.com/scop/57f94f2bf97fb6a2d01349fa59d88530

[gmlewis]

Is there some other dependency that is still requiring that this be imported into this project?

[alexandear]

We can check:

$ go mod why -m gopkg.in/yaml.v3
# gopkg.in/yaml.v3
tools/metadata
github.com/getkin/kin-openapi/openapi3
github.com/go-openapi/jsonpointer
github.com/go-openapi/swag
gopkg.in/yaml.v3

After upgrading the github.com/go-openapi/jsonpointer package, gopkg.in/yaml.v3 will disappear:

go get -u github.com/go-openapi/jsonpointer
go mod tidy

[gmlewis]

Even after running this iteratively, "gopkg.in/yaml.v3" acts like a virus and we can't fully get rid of it yet:

...
$ go get -u github.com/getkin/kin-openapi/openapi3
...
$ go get -u github.com/getkin/kin-openapi/openapi3.text
...
$ go get -u github.com/stretchr/testify/assert
...
$ go get -u github.com/stretchr/testify/assert/yaml
...
$ go mod tidy
$ go mod why -m gopkg.in/yaml.v3
# gopkg.in/yaml.v3
tools/metadata
github.com/getkin/kin-openapi/openapi3
github.com/getkin/kin-openapi/openapi3.test
github.com/stretchr/testify/assert
github.com/stretchr/testify/assert/yaml
gopkg.in/yaml.v3

[ccoVeille]

Did you try a go mod replace ?

The lib are pure port of go-yaml/yaml

[ccoVeille]

it doesn't make sense in a lib like yours, I feel. go mod replace is good for program using your lib.

Testify PR/issue is stale

stretchr/testify#1724

[gmlewis]

No, I didn't try that. Do you want to submit a PR, @ccoVeille ?

[ccoVeille]

No, I didn't try that. Do you want to submit a PR, @ccoVeille ?

As I stated here, it won't be useful for you guys

#3907 (comment)

As go-github is a library and not a software

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.45%. Comparing base (3555113) to head (7133b11).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3907   +/-   ##
=======================================
  Coverage   92.45%   92.45%           
=======================================
  Files         203      203           
  Lines       14980    14980           
=======================================
  Hits        13850    13850           
  Misses        927      927           
  Partials      203      203           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[gmlewis]

@scop - do you want to attempt to bring this PR up-to-date by resolving merge conflicts and trying out the advice posted above from @alexandear, or do you want to start over on a new PR and close this one?

[scop]

Rebased against current master. I did not touch the remaining (note: indirect) dependency because getting rid of it requires updating another package whose effects I have not examined at all. I suggest someone do it in a separate PR if/when desired.

[gmlewis]

Thank you, @scop!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @alexandear - @zyfy29 - @Not-Dhananjay-Mishra

[stevehipwell]

LGTM

[gmlewis]

Thank you, @stevehipwell!
Merging.