-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix!: Add support for missing attributes in ProjectsV2 API #3888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tmelliottjr
wants to merge
4
commits into
google:master
Choose a base branch
from
tmelliottjr:tmelliottjr/update-projects-v2-structs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,027
−71
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1148,44 +1148,6 @@ type FieldValue struct { | |
| To json.RawMessage `json:"to,omitempty"` | ||
| } | ||
|
|
||
| // ProjectV2ItemFieldValue represents a field value of a project item. | ||
| type ProjectV2ItemFieldValue struct { | ||
| ID *int64 `json:"id,omitempty"` | ||
| Name string `json:"name,omitempty"` | ||
| DataType string `json:"data_type,omitempty"` | ||
| // Value set for the field. The type depends on the field type: | ||
| // - text: string | ||
| // - number: float64 | ||
| // - date: string (ISO 8601 date format, e.g. "2023-06-23") or null | ||
| // - single_select: object with "id", "name", "color", "description" fields or null | ||
| // - iteration: object with "id", "title", "start_date", "duration" fields or null | ||
| // - title: object with "text" field (read-only, reflects the item's title) or null | ||
| // - assignees: array of user objects with "login", "id", etc. or null | ||
| // - labels: array of label objects with "id", "name", "color", etc. or null | ||
| // - linked_pull_requests: array of pull request objects or null | ||
| // - milestone: milestone object with "id", "title", "description", etc. or null | ||
| // - repository: repository object with "id", "name", "full_name", etc. or null | ||
| // - reviewers: array of user objects or null | ||
| // - status: object with "id", "name", "color", "description" fields (same structure as single_select) or null | ||
| Value any `json:"value,omitempty"` | ||
| } | ||
|
|
||
| // ProjectV2Item represents an item belonging to a project. | ||
| type ProjectV2Item struct { | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Moved and consolidated with the newer expanded type in |
||
| ID *int64 `json:"id,omitempty"` | ||
| NodeID *string `json:"node_id,omitempty"` | ||
| ProjectNodeID *string `json:"project_node_id,omitempty"` | ||
| ContentNodeID *string `json:"content_node_id,omitempty"` | ||
| ProjectURL *string `json:"project_url,omitempty"` | ||
| ContentType *string `json:"content_type,omitempty"` | ||
| Creator *User `json:"creator,omitempty"` | ||
| CreatedAt *Timestamp `json:"created_at,omitempty"` | ||
| UpdatedAt *Timestamp `json:"updated_at,omitempty"` | ||
| ArchivedAt *Timestamp `json:"archived_at,omitempty"` | ||
| ItemURL *string `json:"item_url,omitempty"` | ||
| Fields []*ProjectV2ItemFieldValue `json:"fields,omitempty"` | ||
| } | ||
|
|
||
| // PublicEvent is triggered when a private repository is open sourced. | ||
| // According to GitHub: "Without a doubt: the best GitHub event." | ||
| // The Webhook event name is "public". | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also moved to colocate with associated ProjectsV2 types. As I understand it, this is not used in events.