chore: Update golangci-lint to v2.7.0#3853
Merged
gmlewis merged 1 commit intogoogle:masterfrom Dec 4, 2025
Merged
Conversation
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
stevehipwell
force-pushed
the
golangci-lint-v2.7.0
branch
from
a21baa5 to
44db530
Compare
alexandear
approved these changes
Dec 4, 2025
gmlewis
approved these changes
Dec 4, 2025
Collaborator
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @stevehipwell and @alexandear!
LGTM.
Merging.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3853 +/- ##
=======================================
Coverage 92.46% 92.46%
=======================================
Files 199 199
Lines 14240 14240
=======================================
Hits 13167 13167
Misses 884 884
Partials 189 189 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alexandear
reviewed
Dec 4, 2025
Comment on lines
+99
to
+100
| if before, _, ok := strings.Cut(text, "</a>"); ok { | ||
| newText := before + strings.Join(innerText, "") |
Contributor
There was a problem hiding this comment.
stringscut may report false positives: golang/go#76687
Contributor
Author
There was a problem hiding this comment.
It looked correct to me, do you think it's wrong?
Collaborator
There was a problem hiding this comment.
If it breaks next time I use it, I'll revert the changes, so no big deal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the currently broken
golangci-lintcustom plugin implementation (broken due to the GitHub Actions Git version). It also makes an auto-fix change that otherwise fails the linter.