feat: Implement Enterprise SCIM - Update Group & User attributes#3848
Merged
gmlewis merged 10 commits intogoogle:masterfrom Dec 3, 2025
Merged
feat: Implement Enterprise SCIM - Update Group & User attributes#3848gmlewis merged 10 commits intogoogle:masterfrom
gmlewis merged 10 commits intogoogle:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3848 +/- ##
==========================================
+ Coverage 92.45% 92.46% +0.01%
==========================================
Files 199 199
Lines 14218 14240 +22
==========================================
+ Hits 13145 13167 +22
Misses 884 884
Partials 189 189 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
elminster-aom
commented
Dec 1, 2025
gmlewis
requested changes
Dec 1, 2025
Collaborator
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @elminster-aom!
Just a few minor tweaks, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.
cc: @stevehipwell - @alexandear - @zyfy29
alexandear
reviewed
Dec 1, 2025
482768a to
97e0188
Compare
alexandear
approved these changes
Dec 2, 2025
gmlewis
approved these changes
Dec 3, 2025
Collaborator
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @elminster-aom and @alexandear!
LGTM.
Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related with #3813
From REST API endpoints for Enterprise SCIM docs, implements:
Update attributes for a SCIM enterprise group, PATCH /scim/v2/enterprises/{enterprise}/Groups/{scim_group_id}
Update attributes for a SCIM enterprise user, PATCH /scim/v2/enterprises/{enterprise}/Users/{scim_user_id}
Other changes: