feat!: Add support for project items CRUD and project fields read operations #3793

stephenotalora · 2025-10-27T21:37:08Z

BREAKING CHANGES:

ProjectV2Field.Options changed from []any to []*ProjectV2FieldOption.
Optional fields in various ProjectV2 structs are now passed as pointers

Closes: #3733.

Based on: #3733

Covers all endpoints for project items : https://docs.github.com/en/rest/projects/items?apiVersion=2022-11-28
Adds support to GET fields on project items, specifically the following REST APIs:

Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

…into add-project-items

…d-project-items

google-cla · 2025-10-27T21:37:14Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

stephenotalora · 2025-10-28T20:31:45Z

Note that you should be able to lint and test locally with ./script/lint.sh and ./script/test.sh.

Thanks! I completely missed the linting errors earlier 🙇🏼

…oth organizations and users

stephenotalora · 2025-10-28T21:08:09Z

Working on additional coverage at the moment 👍🏼

…al API

gmlewis · 2025-10-28T21:48:07Z

@stephenotalora - I'm not sure I understand this comment:

It reconciles merge conflicts between upstream/master and the add-project-items branch by synchronizing the branch with the latest master@v76

Also, please change the title of this PR.

stephenotalora · 2025-10-28T22:01:57Z

@stephenotalora - I'm not sure I understand this comment:

It reconciles merge conflicts between upstream/master and the add-project-items branch by synchronizing the branch with the latest master@v76

Also, please change the title of this PR.

Thanks @gmlewis, updated the PR title and PR description, hoping that's a little more clear, let me know if you have any questions.

gmlewis · 2025-10-28T22:05:58Z

Thanks @gmlewis, updated the PR title and PR description, hoping that's a little more clear, let me know if you have any questions.

So the state of the external-to-this-repo branch called "JoannaaKL:stephenotalora/add-project-items" is irrelevant to this PR and all that information in the description and in the PR title should be removed.

We try to make the PR title helpful to understand what this PR is all about.

How about this:

"feat!: Add methods to edit ProjectsV2 fields"

The "feat!:" part is needed because this PR breaks the API from previous versions.

gmlewis

Your PR title now says "GET" but this PR also includes "POST", "PATCH", and "DELETE" methods, so please make the PR title reflect this.

Before I proceed with this PR review, it looks like this PR has some regressions that were already addressed in #3718.

gmlewis · 2025-10-28T22:46:51Z

github/projects.go

 	UpdatedAt        *Timestamp `json:"updated_at,omitempty"`
 	DeletedAt        *Timestamp `json:"deleted_at,omitempty"`
-	Number           *int       `json:"number,omitempty"`
+	Number           *int64     `json:"number,omitempty"`


There was a discussion about this field being of type int because we felt that a project number would not overflow a 32-bit integer.

Why are you changing this here?

Why are you changing this here?

Thanks @gmlewis, I appreciate you resurfacing the previous discussion; I had missed that context earlier. A couple of points that led to this change:

I took over the base PR, at first glance it appeared there was an intentional effort to transition the projectNumber field to an int64.

To validate the assumption:

I checked our internal database schema and found the field defined as an UNSIGNED BIGINT

Additionally, the OpenAPI specification lists this field as an int64

Both of which reinforced the idea that a wider numeric type might be appropriate in Go.

On second thought, though, an UNSIGNED BIGINT doesn’t directly map to a Go int64, since their ranges differ, while a uint64 would technically align more closely, as you described here that would likely add unnecessary complexity given the low risk of overflow for project numbers.

With that in mind, retaining the int type seems appropriate given the prior context. I can update the PR accordingly 👍🏼

updated: fixed in 25561d3

gmlewis · 2025-10-28T22:48:02Z

github/projects.go

-	Color string `json:"color,omitempty"`
-	// An optional description for this option.
-	Description string `json:"description,omitempty"`
+	ID          *int64 `json:"id,omitempty"`          // The unique identifier for this option.


Why is this being changed from a string?
Actually, it should probably be a *string here if it truly is an optional field.

indeed a string as per our API docs - updated in 27dd1c4

gmlewis · 2025-10-28T22:48:56Z

github/projects.go

+	Name        string `json:"name,omitempty"`        // The display name of the option.
+	Color       string `json:"color,omitempty"`       // The color associated with this option (e.g., "blue", "red").
+	Description string `json:"description,omitempty"` // An optional description for this option.


Optional fields should be pointers to strings in general. I'm not sure why these were left as values in #3718.

fixed in 27dd1c4

gmlewis · 2025-10-28T22:53:59Z

github/projects.go

 //
 //meta:operation GET /orgs/{org}/projectsV2/{project_number}
-func (s *ProjectsService) GetProjectForOrg(ctx context.Context, org string, projectNumber int) (*ProjectV2, *Response, error) {
+func (s *ProjectsService) GetProjectForOrg(ctx context.Context, org string, projectNumber int64) (*ProjectV2, *Response, error) {


Here and below, projectNumber should remain as int unless you have a good reason to change them in this PR.

based on this comment - fixed in 25561d3

stephenotalora · 2025-10-29T18:17:54Z

Your PR title now says "GET" but this PR also includes "POST", "PATCH", and "DELETE" methods, so please make the PR title reflect this.

Yes, thank you 🙇🏼 I went through a rather large conflict earlier, and the title reflected the later additions, that’s my oversight. I’ll update accordingly.

update: I've taken the PR back to a draft while I work on edits.
update-2: @gmlewis PR is ready for another pass, thanks for taking the time to review is much appreciated 🙇🏼

gmlewis

Thank you, @stephenotalora.

gmlewis · 2025-10-29T21:54:45Z

github/projects.go

+// GitHub API docs: https://docs.github.com/rest/projects/fields#list-project-fields-for-user
+//
+//meta:operation GET /users/{username}/projectsV2/{project_number}/fields
+func (s *ProjectsService) ListProjectFieldsForUser(ctx context.Context, user string, projectNumber int, opts *ListProjectsOptions) ([]*ProjectV2Field, *Response, error) {


I seem to recall a conversation we had earlier about changing "*ForUser" to (for example) "ListUserProjectFields" but looking through this go-github repo, I see we have both styles and I can't seem to find the conversation, so I'll leave this now and maybe our other reviewers will have an opinion.

Happy to make this change if there’s a strong preference either way. It would be a breaking change on our end, but easy enough to address. I did a quick search across the repo, and it looks like *ForUser and *ForOrg are used fairly extensively, in about 4 and 12 files, respectively.

gmlewis · 2025-10-29T21:55:19Z

github/projects.go

+// GitHub API docs: https://docs.github.com/rest/projects/fields#get-project-field-for-organization
+//
+//meta:operation GET /orgs/{org}/projectsV2/{project_number}/fields/{field_id}
+func (s *ProjectsService) GetProjectFieldForOrg(ctx context.Context, org string, projectNumber, fieldID int64) (*ProjectV2Field, *Response, error) {


projectNumber should always be int throughout.

Suggested change

func (s *ProjectsService) GetProjectFieldForOrg(ctx context.Context, org string, projectNumber, fieldID int64) (*ProjectV2Field, *Response, error) {

func (s *ProjectsService) GetProjectFieldForOrg(ctx context.Context, org string, projectNumber int, fieldID int64) (*ProjectV2Field, *Response, error) {

Yikes, apologies for missing these 😮‍💨 I've updated all of these similar occurrences under eac21dc

github/projects.go

gmlewis · 2025-10-29T21:56:41Z

github/projects.go

+	NodeID    string                  `json:"node_id,omitempty"`
+	Name      string                  `json:"name,omitempty"`
+	DataType  string                  `json:"dataType,omitempty"`
+	URL       string                  `json:"url,omitempty"`


I know you didn't write these, but optional fields should be reference types.

Thanks for catching these @gmlewis I've updated all in a similar state in 31e34f0 and 032e591

github/projects.go

…nsistency

gmlewis

Thank you, @stephenotalora!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @alexandear - @zyfy29

JoannaaKL and others added 29 commits September 17, 2025 14:31

Add support for projects V2

775f0f6

Add test

74712bd

Address feedback

3a8cf0c

Merge branch 'master' into add-projects

b754eeb

Remove header and rename functions

e93ed36

Update comments

99852cf

Copyright update

7664215

Merge branch 'master' into add-projects

89016d9

Update comments

2b94765

Generate docs

a4b0a56

Add list projects option

696102b

Generate openapi docs

469e03a

Results of generate

2dbe5b4

Merge branch 'master' into add-projects

478ef5a

Merge branch 'master' into add-projects

c34802d

Update github/projects.go

053a9e1

Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Rename url in test

680a0d1

Generate again

d8696b4

Merge branch 'master' into add-projects

93dd34f

Shorten functions for orgs

060aaae

Implemented all endpoints for project items

98c28fa

Remove comments

a4b1014

Merge branch 'master' into add-project-items

57766b6

Merge branch 'master' into add-project-items

e59c224

Add tests

4e935dd

Merge remote-tracking branch 'refs/remotes/origin/add-project-items' …

d18c303

…into add-project-items

More tests

0c5356d

Merge remote-tracking branch 'upstream/master' into stephenotalora/ad…

b2388d1

…d-project-items

fixes all conflicts between upstream/master and add-project-items branch

551885f

stephenotalora added 2 commits October 28, 2025 20:48

Implement methods for retrieving fields by project and field ID for b…

7e69a24

…oth organizations and users

adding generated updates

9191d85

add additional tests to improve coverage for individual field retriev…

521e0ba

…al API

stephenotalora marked this pull request as ready for review October 28, 2025 21:46

stephenotalora changed the title ~~Stephenotalora/add project items~~ Updates add-project-items branch and adds support for field retrieval Oct 28, 2025

stephenotalora changed the title ~~Updates add-project-items branch and adds support for field retrieval~~ Updates add-project-items branch with master and implements field retrieval support Oct 28, 2025

stephenotalora changed the title ~~Updates add-project-items branch with master and implements field retrieval support~~ Updates add-project-items branch with master and adds field retrieval support Oct 28, 2025

gmlewis added NeedsReview PR is awaiting a review before merging. Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). labels Oct 28, 2025

stephenotalora changed the title ~~Updates add-project-items branch with master and adds field retrieval support~~ Feat!: Add methods to GET ProjectsV2 fields Oct 28, 2025

gmlewis changed the title ~~Feat!: Add methods to GET ProjectsV2 fields~~ feat!: Add methods to GET ProjectsV2 fields Oct 28, 2025

gmlewis requested changes Oct 28, 2025

View reviewed changes

stephenotalora changed the title ~~feat!: Add methods to GET ProjectsV2 fields~~ feat!: Additional support for project items and fields CRUD operations Oct 29, 2025

stephenotalora marked this pull request as draft October 29, 2025 18:43

stephenotalora changed the title ~~feat!: Additional support for project items and fields CRUD operations~~ feat!: Add support for project items CRUD and project fields read operations Oct 29, 2025

stephenotalora added 2 commits October 29, 2025 13:12

reverts projectNumber from int64 to int

25561d3

fixes ProjectV2FieldOption.ID type from int64 to string

27dd1c4

stephenotalora marked this pull request as ready for review October 29, 2025 21:18

stephenotalora requested a review from gmlewis October 29, 2025 21:21

gmlewis requested changes Oct 29, 2025

View reviewed changes

stephenotalora added 3 commits October 29, 2025 16:30

ensures projectNumber is an int across the board

eac21dc

makes all optional fields in existing structs reference types

31e34f0

additional updates following struct changes to reference types for co…

032e591

…nsistency

gmlewis approved these changes Oct 29, 2025

View reviewed changes

	func (s ProjectsService) GetProjectFieldForOrg(ctx context.Context, org string, projectNumber, fieldID int64) (ProjectV2Field, *Response, error) {
	func (s ProjectsService) GetProjectFieldForOrg(ctx context.Context, org string, projectNumber int, fieldID int64) (ProjectV2Field, *Response, error) {

Uh oh!

feat!: Add support for project items CRUD and project fields read operations #3793

Are you sure you want to change the base?

feat!: Add support for project items CRUD and project fields read operations #3793

Conversation

stephenotalora commented Oct 27, 2025 • edited by gmlewis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

google-cla bot commented Oct 27, 2025

Uh oh!

stephenotalora commented Oct 28, 2025

Uh oh!

stephenotalora commented Oct 28, 2025

Uh oh!

gmlewis commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stephenotalora commented Oct 28, 2025

Uh oh!

gmlewis commented Oct 28, 2025

Uh oh!

gmlewis left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stephenotalora Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stephenotalora Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stephenotalora commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gmlewis left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stephenotalora Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gmlewis left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

stephenotalora commented Oct 27, 2025 •

edited by gmlewis

Loading

gmlewis commented Oct 28, 2025 •

edited

Loading

stephenotalora Oct 29, 2025 •

edited

Loading

stephenotalora Oct 29, 2025 •

edited

Loading

stephenotalora commented Oct 29, 2025 •

edited

Loading

stephenotalora Oct 29, 2025 •

edited

Loading