-
Notifications
You must be signed in to change notification settings - Fork 2.2k
chore: Add new lint rule to make sure exported names documented #3682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
838cf52
9236504
eabdef5
59e9a5f
af88e93
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -22,8 +22,8 @@ type tagProtectionRequest struct { | |||||||||||
Pattern string `json:"pattern"` | ||||||||||||
} | ||||||||||||
|
||||||||||||
// Deprecated: ListTagProtection lists tag protection of the specified repository. | ||||||||||||
// Deprecation notice: This operation is deprecated and will be removed after August 30, 2024. Use the "Repository Rulesets" endpoint instead: https://docs.github.com/rest/repos/rules#get-all-repository-rulesets | ||||||||||||
// ListTagProtection lists tag protection of the specified repository. | ||||||||||||
// Deprecated: This operation is deprecated and will be removed after August 30, 2024. Use the "Repository Rulesets" endpoint instead: https://docs.github.com/rest/repos/rules#get-all-repository-rulesets | ||||||||||||
// | ||||||||||||
// GitHub API docs: https://docs.github.com/rest/repos/tags#closing-down---list-tag-protection-states-for-a-repository | ||||||||||||
// | ||||||||||||
|
@@ -45,8 +45,8 @@ func (s *RepositoriesService) ListTagProtection(ctx context.Context, owner, repo | |||||||||||
return tagProtections, resp, nil | ||||||||||||
} | ||||||||||||
|
||||||||||||
// Deprecated: CreateTagProtection creates the tag protection of the specified repository. | ||||||||||||
// Deprecation notice: This operation is deprecated and will be removed after August 30, 2024. Use the "Repository Rulesets" endpoint instead: https://docs.github.com/rest/repos/rules#create-a-repository-ruleset | ||||||||||||
// CreateTagProtection creates the tag protection of the specified repository. | ||||||||||||
// Deprecated: This operation is deprecated and will be removed after August 30, 2024. Use the "Repository Rulesets" endpoint instead: https://docs.github.com/rest/repos/rules#create-a-repository-ruleset | ||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||
// | ||||||||||||
// GitHub API docs: https://docs.github.com/rest/repos/tags#closing-down---create-a-tag-protection-state-for-a-repository | ||||||||||||
// | ||||||||||||
|
@@ -68,8 +68,8 @@ func (s *RepositoriesService) CreateTagProtection(ctx context.Context, owner, re | |||||||||||
return tagProtection, resp, nil | ||||||||||||
} | ||||||||||||
|
||||||||||||
// Deprecated: DeleteTagProtection deletes a tag protection from the specified repository. | ||||||||||||
// Deprecation notice: This operation is deprecated and will be removed after August 30, 2024. Use the "Repository Rulesets" endpoint instead: https://docs.github.com/rest/repos/rules#delete-a-repository-ruleset | ||||||||||||
// DeleteTagProtection deletes a tag protection from the specified repository. | ||||||||||||
// Deprecated: This operation is deprecated and will be removed after August 30, 2024. Use the "Repository Rulesets" endpoint instead: https://docs.github.com/rest/repos/rules#delete-a-repository-ruleset | ||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'll fix it, thank you! |
||||||||||||
// | ||||||||||||
// GitHub API docs: https://docs.github.com/rest/repos/tags#closing-down---delete-a-tag-protection-state-for-a-repository | ||||||||||||
// | ||||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There must be an empty line before
Deprecated:
to be properly recognized with pkg.go.dev.Without empty line:
With empty line: