Skip to content

fix: Typos in func parameter, vars, error, and comments #3442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2025
Merged

fix: Typos in func parameter, vars, error, and comments #3442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion example/verifyartifact/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ func getPolicyBuilder() (*verify.PolicyBuilder, error) {
return nil, err
}

// Set up the articaft policy
// Set up the artifact policy
artifactDigestBytes, err := hex.DecodeString(*artifactDigest)
if err != nil {
return nil, err
Expand Down
2 changes: 1 addition & 1 deletion github/github.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -987,7 +987,7 @@ func (c *Client) bareDoUntilFound(ctx context.Context, req *http.Request, maxRed
if maxRedirects <= 0 && rerr.StatusCode == http.StatusMovedPermanently {
return nil, response, fmt.Errorf("reached the maximum amount of redirections: %w", err)
}
return nil, response, fmt.Errorf("unexepected redirection response: %w", err)
return nil, response, fmt.Errorf("unexpected redirection response: %w", err)
}
}

Expand Down
6 changes: 3 additions & 3 deletions github/repos_deployments_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,14 +186,14 @@ func TestRepositoriesService_ListDeploymentStatuses(t *testing.T) {

opt := &ListOptions{Page: 2}
ctx := context.Background()
statutses, _, err := client.Repositories.ListDeploymentStatuses(ctx, "o", "r", 1, opt)
statuses, _, err := client.Repositories.ListDeploymentStatuses(ctx, "o", "r", 1, opt)
if err != nil {
t.Errorf("Repositories.ListDeploymentStatuses returned error: %v", err)
}

want := []*DeploymentStatus{{ID: Ptr(int64(1))}, {ID: Ptr(int64(2))}}
if !cmp.Equal(statutses, want) {
t.Errorf("Repositories.ListDeploymentStatuses returned %+v, want %+v", statutses, want)
if !cmp.Equal(statuses, want) {
t.Errorf("Repositories.ListDeploymentStatuses returned %+v, want %+v", statuses, want)
}

const methodName = "ListDeploymentStatuses"
Expand Down
4 changes: 2 additions & 2 deletions github/teams_discussion_comments.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,8 +167,8 @@ func (s *TeamsService) CreateCommentByID(ctx context.Context, orgID, teamID int6
// GitHub API docs: https://docs.github.com/rest/teams/discussion-comments#create-a-discussion-comment
//
//meta:operation POST /orgs/{org}/teams/{team_slug}/discussions/{discussion_number}/comments
func (s *TeamsService) CreateCommentBySlug(ctx context.Context, org, slug string, discsusionNumber int, comment DiscussionComment) (*DiscussionComment, *Response, error) {
u := fmt.Sprintf("orgs/%v/teams/%v/discussions/%v/comments", org, slug, discsusionNumber)
func (s *TeamsService) CreateCommentBySlug(ctx context.Context, org, slug string, discussionNumber int, comment DiscussionComment) (*DiscussionComment, *Response, error) {
u := fmt.Sprintf("orgs/%v/teams/%v/discussions/%v/comments", org, slug, discussionNumber)
req, err := s.client.NewRequest("POST", u, comment)
if err != nil {
return nil, nil, err
Expand Down
Loading