Skip to content

Conversation

mumoshu
Copy link
Contributor

@mumoshu mumoshu commented Sep 23, 2021

This adds support for new workflow_job webhook events' labels field announced at https://github.blog/changelog/2021-09-20-github-actions-ephemeral-self-hosted-runners-new-webhooks-for-auto-scaling/.

I've already using go-github with this patch for weeks while participating in the alpha test of the new webhook event. So I'm pretty confident this works. But I'd do anything I can do if necessary!

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Sep 23, 2021
@mumoshu mumoshu changed the title Add support for workflow_job event Add support for workflow_job event's labels field Sep 24, 2021
@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #2103 (8fe5df7) into master (55021d5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2103   +/-   ##
=======================================
  Coverage   97.77%   97.77%           
=======================================
  Files         109      109           
  Lines        9726     9726           
=======================================
  Hits         9510     9510           
  Misses        150      150           
  Partials       66       66           
Impacted Files Coverage Δ
github/actions_workflow_jobs.go 100.00% <ø> (ø)
github/event_types.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55021d5...8fe5df7. Read the comment docs.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mumoshu !
LGTM.
Merging.

@gmlewis gmlewis merged commit e880e71 into google:master Sep 24, 2021
@mumoshu mumoshu deleted the workflow-job-event branch September 24, 2021 04:40
@Lazyshot Lazyshot mentioned this pull request Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants