Skip to content

Revert mistakenly added fields in DraftReviewComment #3219

@matt-simons

Description

@matt-simons

In #3169 I mistakenly added CommitID, InReplyTo, and SubjectType to DraftReviewComment while referring to https://docs.github.com/en/rest/pulls/reviews?apiVersion=2022-11-28#create-a-review-for-a-pull-request. These fields are not however supported in the comments array of https://docs.github.com/en/rest/pulls/reviews?apiVersion=2022-11-28#create-a-review-for-a-pull-request which is what DraftReviewComment was intended for. Sorry for the confusion and time wasted.

My intention was to mimic the workflow in the github UI where you can submit a pull request review with review comments on files instead of a line numbers, however on second look I don't think this is possible to do via the API, please correct me if I'm wrong again.

Revert for PR #3218

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions