Only attempt to mount for MountableLayer #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #401 +/- ##
=========================================
- Coverage 52.11% 52.1% -0.02%
=========================================
Files 78 78
Lines 3711 3710 -1
=========================================
- Hits 1934 1933 -1
Misses 1484 1484
Partials 293 293
Continue to review full report at Codecov.
|
vdemeester
approved these changes
Mar 8, 2019
mattmoor
reviewed
Mar 8, 2019
mattmoor
approved these changes
Mar 8, 2019
vdemeester
added a commit
to vdemeester/kaniko
that referenced
this pull request
Mar 11, 2019
The main reason is to include the fixes from google/go-containerregistry#401. This should fix the build+push to quay.io (with v2 schema enabled) cases. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
dlorenc
pushed a commit
to GoogleContainerTools/kaniko
that referenced
this pull request
Mar 11, 2019
…#609) The main reason is to include the fixes from google/go-containerregistry#401. This should fix the build+push to quay.io (with v2 schema enabled) cases. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uploading to Quay is failing with
INVALID_REQUEST: Invalid request. My theory is this mounting quirk, but we still need to confirm this fixes things before merging.